Jackie-Jiang commented on code in PR #15888:
URL: https://github.com/apache/pinot/pull/15888#discussion_r2105258895
##########
.github/workflows/pinot_tests.yml:
##########
@@ -76,6 +76,30 @@ jobs:
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
run: .github/workflows/scripts/.pinot_linter.sh
+
+ binary-compat-check:
+ if: github.repository == 'apache/pinot'
+ runs-on: ubuntu-latest
+ name: Pinot Binary Compatibility Check
+ steps:
+ - uses: actions/checkout@v4
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ java-version: 11
+ distribution: 'temurin'
+ cache: 'maven'
+ # Step that does that actual cache save and restore
+ - uses: actions/cache@v4
+ env:
+ SEGMENT_DOWNLOAD_TIMEOUT_MINS: 10
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ - name: Verify with binary-compatibility-check profile
+ run: mvn verify -DskipTests -Pbinary-compat-check -T1C
Review Comment:
Should we only build SPI and segment SPI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
