abhishekbafna commented on code in PR #15839:
URL: https://github.com/apache/pinot/pull/15839#discussion_r2104337544


##########
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##########
@@ -773,10 +796,14 @@ public void 
processQueryRateLimitingExternalViewChange(ExternalView currentBroke
       int onlineBrokerCount = otherOnlineBrokerCount + 1;
 
       // Get stat from property store
-      String tableConfigPath = constructTableConfigPath(tableNameWithType);
-      Stat stat = _propertyStore.getStat(tableConfigPath, 
AccessOption.PERSISTENT);
+      String physicalOrLogicalTableConfigPath =
+          ZKMetadataProvider.isTableConfigExists(_propertyStore, 
physicalOrLogicalTableName)

Review Comment:
   No. This is called here.
   
   ```
     public void processClusterChange(HelixConstants.ChangeType changeType) {
       .....
       if (changeType == HelixConstants.ChangeType.EXTERNAL_VIEW) {
         ExternalView brokerResourceEV = getBrokerResource();
         processQueryRateLimitingExternalViewChange(brokerResourceEV);
       }
       ....
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to