bziobrowski commented on code in PR #15591:
URL: https://github.com/apache/pinot/pull/15591#discussion_r2097290682
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##########
@@ -355,7 +415,9 @@ public static class Builder {
private PartitionFunction _partitionFunction;
private Set<Integer> _partitions;
private boolean _autoGenerated;
- private Map<IndexType<?, ?, ?>, Long> _indexSizeMap = new HashMap<>();
+
+ // use non-default size to save space for most columns
+ LongArrayList _indexSizeList = new LongArrayList(2);
Review Comment:
Collection is in the builder already. By update did you mean adding to index
size map ? Code responsible for that puts data into ColumnMetadataImpl ( way
after instance is built by builder) in master already. Should I refactor
SegmentMetadataImpl then ? I was trying to minimize changes so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
