Jackie-Jiang commented on code in PR #15830:
URL: https://github.com/apache/pinot/pull/15830#discussion_r2096652063
##########
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java:
##########
@@ -1372,7 +1373,7 @@ public void testLuceneRealtimeWithSearcherManager()
// create and open an index writer
File indexFile = new File(INDEX_DIR.getPath() + "/realtime-test1.index");
Directory indexDirectory = FSDirectory.open(indexFile.toPath());
- StandardAnalyzer standardAnalyzer = new StandardAnalyzer();
+ Analyzer standardAnalyzer = new CaseAwareStandardAnalyzer();
Review Comment:
(nit) Same for other places
```suggestion
Analyzer analyzer = new CaseAwareStandardAnalyzer();
```
##########
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java:
##########
@@ -1674,7 +1675,7 @@ private static class RealtimeReader implements Runnable {
private final QueryParser _queryParser;
private final SearcherManager _searcherManager;
- RealtimeReader(SearcherManager searcherManager, StandardAnalyzer
standardAnalyzer) {
+ RealtimeReader(SearcherManager searcherManager, Analyzer standardAnalyzer)
{
Review Comment:
```suggestion
RealtimeReader(SearcherManager searcherManager, Analyzer analyzer) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
