xiangfu0 commented on PR #15803: URL: https://github.com/apache/pinot/pull/15803#issuecomment-2888166150
> > What do you think about just reusing the existing Analyzer class config to enable this? I see case sensitivity eventually being necessary for multiple analyzers, but the config only enables a case sensitive StandardAnalyzer. MV column text search is another case where different analyzer is useful (to prevent the value boundary being crossed for phrases). I see some value in Pinot including a number of Analyzers in the future for users to choose from, some of which should be case sensitive > > Right now the logic can become more complex if we make a future adjustment to the StandardAnalyzer, since configs will generally be mutually exclusive or require some branching when adding more derivations of the StandardAnalyzer to cover all combinations of configs like this > > I think the config here is mainly for simplifying the usage for normal users, so they don't have to specify the `org.apache.pinot.segment.local.segment.index.text.CaseSensitiveAnalyzer`. > > If the concern is more on the diverge of `StandardAnalyzer`, I feel we could just use `CaseSensitiveAnalyzer` as default and configurable to use `LowerCaseFilter` for the current default use cases. I will merge this PR for now to unblock the users. And will make another one to refactor the Analyzer, we can use that PR to discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
