jadami-stripe opened a new issue, #15827: URL: https://github.com/apache/pinot/issues/15827
https://github.com/apache/pinot/pull/12464 attempted to address this, but it only did so for 1 case. [MutableSegmentImpl](https://sourcegraph.com/github.com/apache/pinot/-/blob/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java?L1271) has several other checks where it will just turn off ingestion aggregation if failed. This creates a lot of confusion for users when all the metrics are 0, and there's no explanation why. I would say at minimum, the same checks in https://sourcegraph.com/github.com/apache/pinot/-/blob/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java?L1271 should apply on table creation/update. But I also wonder if `enableMetricsAggregationIfPossible` needs to be changed to just fail. If I had to pick between silently returning wrong data (an incident we already had once) or lagging/eventually failing queries, the latter seems better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
