gortiz commented on code in PR #15764: URL: https://github.com/apache/pinot/pull/15764#discussion_r2086058183
########## pinot-tools/src/main/java/org/apache/pinot/tools/ColocatedJoinEngineQuickStart.java: ########## @@ -1,67 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.pinot.tools; - -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Collections; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import org.apache.pinot.spi.utils.CommonConstants; -import org.apache.pinot.tools.admin.PinotAdministrator; - - -public class ColocatedJoinEngineQuickStart extends MultistageEngineQuickStart { - private static final String QUICKSTART_IDENTIFIER = "COLOCATED_JOIN"; - private static final String[] COLOCATED_JOIN_DIRECTORIES = new String[]{ - "examples/batch/colocated/userAttributes", "examples/batch/colocated/userGroups" - }; Review Comment: Any reason to remove this quickstart? It's actually the one I use the most. Not because of the configs, which are equal to the defaults, but because: - Tables are configured exactly as needed for colocation - There are few tables than in other quickstart and therefore it starts faster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
