Jackie-Jiang commented on code in PR #15766:
URL: https://github.com/apache/pinot/pull/15766#discussion_r2085476441
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexService.java:
##########
@@ -53,18 +56,42 @@
*/
@ThreadSafe
public class IndexService {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(IndexService.class);
private static volatile IndexService _instance = fromServiceLoader();
private final List<IndexType<?, ?, ?>> _allIndexes;
private final Map<String, IndexType<?, ?, ?>> _allIndexesById;
- private IndexService(Set<IndexPlugin<?>> allPlugins) {
- ImmutableMap.Builder<String, IndexType<?, ?, ?>> builder =
ImmutableMap.builder();
+ public IndexService(Set<IndexPlugin<?>> allPlugins) {
Review Comment:
(minor) Is this exposed just for testing purpose? If so, I'd suggest making
it package private, and add `@VisibleForTesting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
