Copilot commented on code in PR #15624:
URL: https://github.com/apache/pinot/pull/15624#discussion_r2062666847
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SchemaConformingTransformer.java:
##########
@@ -406,25 +408,25 @@ public GenericRow transform(GenericRow record) {
* @return ExtraFieldsContainer carries the indexable and unindexable fields
of the current node as well as its
* subtree
*/
- private ExtraFieldsContainer processField(SchemaTreeNode parentNode,
Deque<String> jsonPath, Object value,
- boolean isIndexable, GenericRow outputRecord, Map<String, Object>
mergedTextIndexMap) {
+ private void processField(SchemaTreeNode parentNode, List<String> jsonPath,
Object value,
Review Comment:
Update the Javadoc for processField to reflect its new behavior: performing
in-place modifications and returning void instead of an ExtraFieldsContainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
