praveenc7 commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2060540330
##########
pinot-common/src/thrift/query.thrift:
##########
@@ -32,6 +32,7 @@ struct PinotQuery {
11: optional map<string, string> queryOptions;
12: optional bool explain;
13: optional map<Expression, Expression> expressionOverrideHints;
+ 14: optional bool selectStarQuery;
Review Comment:
When the broker sends the request to server, we
[expand](https://github.com/apache/pinot/blob/c781ff1fff5bd770311d9da85f22c1df9f10077c/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java#L1733)
* column to actual physical columns
So our options are either use this or have a querpOptions indicating this
info to the server. Given QueryOptions felt hacky or not clean, so used this
thrift proto to pass-down the info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
