abhishekbafna commented on code in PR #15515:
URL: https://github.com/apache/pinot/pull/15515#discussion_r2059552752
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -216,11 +241,19 @@ public boolean
registerTableConfigChangeListener(TableConfigChangeListener table
}
/**
- * Returns the schema for the given table, or {@code null} if it does not
exist.
+ * Returns the schema for the given logical or physical table, or {@code
null} if it does not exist.
*/
@Nullable
@Override
public Schema getSchema(String rawTableName) {
+ if (isLogicalTable(rawTableName)) {
+ return getLogicalTableSchema(rawTableName);
+ } else {
+ return getPhysicalTableSchema(rawTableName);
+ }
+ }
+
+ private Schema getPhysicalTableSchema(String rawTableName) {
Review Comment:
`getSchema` already exists and it calls table specific get schema.
```
public Schema getSchema(String rawTableName) {
if (isLogicalTable(rawTableName)) {
return getLogicalTableSchema(rawTableName);
} else {
return getPhysicalTableSchema(rawTableName);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
