Jackie-Jiang commented on code in PR #15407: URL: https://github.com/apache/pinot/pull/15407#discussion_r2053102277
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/FixedByteSVMutableForwardIndex.java: ########## @@ -84,6 +100,19 @@ public FixedByteSVMutableForwardIndex(boolean dictionaryEncoded, DataType stored _chunkSizeInBytes = (long) numRowsPerChunk * _valueSizeInBytes; _memoryManager = memoryManager; _allocationContext = allocationContext; + + // Initialize dynamic buffer sizing parameters from system properties + _dynamicBufferSizingEnabled = Boolean.parseBoolean( + System.getProperty(DYNAMIC_BUFFER_SIZING_ENABLED_KEY, Review Comment: Pinot doesn't rely on system properties. These should be introduced as forward index config in table config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org