Jackie-Jiang commented on code in PR #15263:
URL: https://github.com/apache/pinot/pull/15263#discussion_r2052738566
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -971,7 +971,7 @@ Object[][]
polymorphicScalarComparisonFunctionsDataProvider() {
inputs.add(new Object[]{"INT", "1", "0", "1"});
inputs.add(new Object[]{"LONG", "12345678999", "12345678998",
"12345678999"});
inputs.add(new Object[]{"FLOAT", "CAST(1.234 AS FLOAT)", "CAST(1.23 AS
FLOAT)", "1.234"});
- inputs.add(new Object[]{"DOUBLE", "1.234", "1.23", "1.234"});
+ inputs.add(new Object[]{"DOUBLE", "CAST(1.234 AS DOUBLE)", "CAST(1.23 AS
DOUBLE)", "1.234"});
Review Comment:
Just curious, do we still need this change?
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotEvaluateLiteralRule.java:
##########
@@ -258,13 +275,18 @@ private static Object convertResultValue(@Nullable Object
resultValue, RelDataTy
return TimestampUtils.toMillisSinceEpoch(resultValue.toString());
}
}
- // Return BigDecimal for numbers
- if (resultValue instanceof Integer || resultValue instanceof Long) {
+ // Use BigDecimal for INTEGER / BIGINT / DECIMAL literals
Review Comment:
In SSE, we use int for INTEGER and long for BIGINT, should we keep it
consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
