bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2050690066
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ########## @@ -88,7 +87,8 @@ public ImmutableSegmentImpl(SegmentDirectory segmentDirectory, SegmentMetadataIm _segmentMetadata = segmentMetadata; _indexContainerMap = columnIndexContainerMap; _starTreeIndexContainer = starTreeIndexContainer; Review Comment: Should be fine because map is keyed by String (which caches hashcode) and we know map size ahead of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org