Jackie-Jiang commented on code in PR #15529:
URL: https://github.com/apache/pinot/pull/15529#discussion_r2047986635
##########
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java:
##########
@@ -37,6 +37,13 @@ public class ScalarFunctions {
private ScalarFunctions() {
}
+ /**
+ * Maximum number of cells that can be returned by the gridDisk function.
This is configurable via the system property
+ * "pinot.geospatial.gridDisk.maxCells". Default value is 100,000 cells.
+ */
+ public static final int MAX_GRID_DISK_CELLS = Integer.parseInt(
Review Comment:
Pinot doesn't usually read config from system properties. If you really want
to bound this, consider making it a broker config, and reject the query when
`k` is too large. You can find examples in
`BaseSingleStageBrokerRequestHandler`. One drawback is that it is not honored
for multi-stage engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
