Jackie-Jiang commented on code in PR #15562:
URL: https://github.com/apache/pinot/pull/15562#discussion_r2047670962
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java:
##########
@@ -38,9 +37,7 @@ class SingletonExchange extends BlockExchange {
SingletonExchange(List<SendingMailbox> sendingMailboxes, BlockSplitter
splitter,
Function<List<SendingMailbox>, Integer> statsIndexChooser) {
super(sendingMailboxes, splitter, statsIndexChooser);
- Preconditions.checkArgument(
- sendingMailboxes.size() == 1 && sendingMailboxes.get(0) instanceof
InMemorySendingMailbox,
- "Expect single InMemorySendingMailbox for SingletonExchange");
+ Preconditions.checkArgument(sendingMailboxes.size() == 1, "Expect single
mailbox in Singleton Exchange");
Review Comment:
Do we need to change this? We don't want it to send data across servers.
Currently singleton means local exchange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
