pengding-stripe opened a new issue, #15543: URL: https://github.com/apache/pinot/issues/15543
Pinot has this [check](https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceTagPoolSelector.java#L110) to ensure the available pools in the tenant >= numPools of the table config. However, when numPools is set to 0, this check is always successful. This brings an issue of putting replicas more than available pools and instances are randomly assigned to each replica. For example, I set the replication of table to 3 but there are only 2 pools of instances in the tenant, rebalance gives below response. ``` "instanceAssignment": { "OFFLINE": { "instancePartitionsName": "instancechange_offline_v1_OFFLINE", "partitionToInstancesMap": { "0_0": [ "Server_ps-adhoc-instancechange-uswest2b-2_8098" ], "0_1": [ "Server_ps-adhoc-instancechange-uswest2a-2_8098" ], "0_2": [ "Server_ps-adhoc-instancechange-uswest2b-3_8098" ] } } }, ``` If I set replication to 2, rebalance gives: ``` "instanceAssignment": { "OFFLINE": { "instancePartitionsName": "instancechange_offline_v1_OFFLINE", "partitionToInstancesMap": { "0_0": [ "Server_ps-adhoc-instancechange-uswest2b-1_8098", "Server_ps-adhoc-instancechange-uswest2b-2_8098", "Server_ps-adhoc-instancechange-uswest2b-3_8098" ], "0_1": [ "Server_ps-adhoc-instancechange-uswest2a-1_8098", "Server_ps-adhoc-instancechange-uswest2a-2_8098", "Server_ps-adhoc-instancechange-uswest2a-3_8098" ] } } }, ``` rebalance would cause availability and capacity issue. numPools is default to 0 to be adaptive, I'm not sure this is expected behavior or a bug of Pinot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
