(pinot) branch master updated: Reducing the metric complexity. Partitions level information can still be obtained by using avg over the metric. (#15470)

[kharekartik]

This is an automated email from the ASF dual-hosted git repository.

kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e6d8dbb03 Reducing the metric complexity. Partitions level 
information can still be obtained by using avg over the metric. (#15470)
8e6d8dbb03 is described below

commit 8e6d8dbb03b6bc94651b0624963c1999ecd8d144
Author: 9aman <35227405+9a...@users.noreply.github.com>
AuthorDate: Wed Apr 9 10:41:27 2025 +0530

    Reducing the metric complexity. Partitions level information can still be 
obtained by using avg over the metric. (#15470)
---
 .../controller/helix/core/realtime/SegmentCompletionManager.java | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git 
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
 
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
index 687ae81375..7607f2114a 100644
--- 
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
+++ 
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
@@ -139,17 +139,12 @@ public class SegmentCompletionManager {
     }
 
     if (factoryName == null) {
-      // Create a metric identifier at partition level granularity, similar to 
server metrics
-      // in RealtimeSegmentValidationManager
-      String tableNameAndPartitionGroupId = realtimeTableName + "-" + 
llcSegmentName.getPartitionGroupId();
       if (PauselessConsumptionUtils.isPauselessEnabled(tableConfig)) {
         factoryName = _segmentCompletionConfig.getDefaultPauselessFsmScheme();
-        _controllerMetrics.setValueOfTableGauge(tableNameAndPartitionGroupId,
-            ControllerGauge.PAUSELESS_CONSUMPTION_ENABLED, 1);
+        _controllerMetrics.setValueOfTableGauge(realtimeTableName, 
ControllerGauge.PAUSELESS_CONSUMPTION_ENABLED, 1);
       } else {
         factoryName = _segmentCompletionConfig.getDefaultFsmScheme();
-        _controllerMetrics.setValueOfTableGauge(tableNameAndPartitionGroupId,
-            ControllerGauge.PAUSELESS_CONSUMPTION_ENABLED, 0);
+        _controllerMetrics.setValueOfTableGauge(realtimeTableName, 
ControllerGauge.PAUSELESS_CONSUMPTION_ENABLED, 0);
       }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org