somandal commented on code in PR #15479:
URL: https://github.com/apache/pinot/pull/15479#discussion_r2033668307
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/BaseSegmentOperationsThrottler.java:
##########
@@ -92,6 +92,17 @@ public BaseSegmentOperationsThrottler(int maxConcurrency,
int maxConcurrencyBefo
availablePermits());
}
+ /**
+ * The ServerMetrics may be created after these throttle objects are
created. In that case, the initialization that
+ * happens in the constructor may have occurred on the NOOP metrics. This
should be called after the server metrics
+ * are created and registered to ensure the correct metrics object is used
and the metrics are updated correctly
+ */
+ public void initializeMetrics() {
Review Comment:
done, yes that's right so left a comment about that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
