abhishekbafna commented on code in PR #15473:
URL: https://github.com/apache/pinot/pull/15473#discussion_r2032362232
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -241,55 +290,64 @@ protected void removeSegmentFromStore(String
tableNameWithType, String segmentId
String rawTableName =
TableNameBuilder.extractRawTableName(tableNameWithType);
URI fileToDeleteURI = getFileToDeleteURI(rawTableName, segmentId);
if (fileToDeleteURI == null) {
- LOGGER.warn("No segment file found for segment: {} in deep store,
skipping deletion", segmentId);
Review Comment:
This is redundant. A similar log statement is logged by the
`getFileToDeleteURI` method.
```LOGGER.error("No file found for segment: {} in deep store", segmentId);```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
