J-HowHuang opened a new pull request, #15317:
URL: https://github.com/apache/pinot/pull/15317
## Description
Some options in `RebalanceConfig` in rebalance API need to be double checked
before execution:
- if `bestEffort=true`, flag it
- if `downtime=true`, but replication > 1, flag it
- if `includeConsuming=false`, but `tableType=REALTIME`, flag it
- if `minimizeDataMovement=false` and instance assignment is allowed, flag it
- if `bootstrap=true`, flag it
- if # of replica cannot satisfy `minAvailableReplicas`, flag it
## Examples
When everything passed
```
"preChecksResult": {
"isMinimizeDataMovement": {
...
},
"diskUtilizationDuringRebalance": {
...
},
"diskUtilizationAfterRebalance": {
...
},
"needsReloadStatus": {
...
},
"rebalanceConfigOptions": {
"preCheckStatus": "PASS",
"message": ""
}
}
```
Some example warnings:
```
"preChecksResult": {
"isMinimizeDataMovement": {
...
},
"diskUtilizationDuringRebalance": {
...
},
"diskUtilizationAfterRebalance": {
...
},
"needsReloadStatus": {
...
},
"rebalanceConfigOptions": {
"preCheckStatus": "WARN",
"message": "bestEfforts is enabled, only enable it if you know what
you are doing
Number of replicas (3) is greater than 1, downtime is not recommended.
The number of replicas (1) is less than minAvailableReplicas. The rebalance
would fail.
includeConsuming is disabled for a realtime table.
bootstrap is enabled, only enable it if you know what you are doing
"
}
}
```
Note: this PR is based on #15175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
