9aman commented on code in PR #15316:
URL: https://github.com/apache/pinot/pull/15316#discussion_r2007012278
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java:
##########
@@ -100,8 +100,9 @@ public static List<Map<String, String>>
getStreamConfigMaps(TableConfig tableCon
}
return streamConfigMaps;
}
- if (tableConfig.getIndexingConfig() != null &&
tableConfig.getIndexingConfig().getStreamConfigs() != null) {
- return Arrays.asList(tableConfig.getIndexingConfig().getStreamConfigs());
+ IndexingConfig indexingConfig = tableConfig.getIndexingConfig();
Review Comment:
Is there a reason for removing the null check for indexingConfig while
keeping it for IngestionConfig ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
