somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025965383
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -299,7 +299,7 @@ public void setUp()
_executorService = Executors.newFixedThreadPool(10);
preChecker.init(_helixResourceManager, _executorService,
_controllerConfig.getDiskUtilizationThreshold());
_tableRebalancer = new
TableRebalancer(_resourceManager.getHelixZkManager(), null, null, preChecker,
- _resourceManager.getTableSizeReader());
+ _resourceManager.getTableSizeReader(), null);
Review Comment:
nit: should we pass in the `consumingSegmentInfoReader` here and just verify
that the test doesn't fail? that way the code path is exercised with a real
`consumingSegmentInfoReader` object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
