rhodo opened a new pull request, #15429: URL: https://github.com/apache/pinot/pull/15429
This PR is a follow-up to the [previous work](https://github.com/apache/pinot/pull/14717) on making PinotTaskManager fully pluggable. Currently, the issue is that the controller starter always creates a default PinotTaskManager instance, even when we want to use a custom, pluggable implementation. To address this, we adopt the same approach used for PlanMaker ([reference](https://github.com/apache/pinot/pull/10269/files)): using reflection to dynamically load the desired PinotTaskManager implementation. Existing [PinotTaskManagerStatelessTest](https://github.com/apache/pinot/blob/c57c166ccb00b54439374369c1744cefc83d39f7/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java) will still cover this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
