J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2027412227
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ########## @@ -19,33 +19,25 @@ package org.apache.pinot.controller.helix.core.rebalance; import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyOrder; +import java.util.Objects; /** * These are rebalance stats as to how the current state is, when compared to the target state. * Eg: If the current has 4 segments whose replicas (16) don't match the target state, _segmentsToRebalance * is 4 and _replicasToRebalance is 16. */ Review Comment: Should this be updated? They're old variables ########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ########## @@ -19,33 +19,25 @@ package org.apache.pinot.controller.helix.core.rebalance; import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyOrder; +import java.util.Objects; /** * These are rebalance stats as to how the current state is, when compared to the target state. * Eg: If the current has 4 segments whose replicas (16) don't match the target state, _segmentsToRebalance * is 4 and _replicasToRebalance is 16. */ Review Comment: Should this be updated? They're old variables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
