ankitsultana commented on code in PR #15402: URL: https://github.com/apache/pinot/pull/15402#discussion_r2024016047
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -456,6 +456,9 @@ public static class Broker { public static final String CONFIG_OF_BROKER_ENABLE_MULTISTAGE_MIGRATION_METRIC = "pinot.broker.enable.multistage.migration.metric"; public static final boolean DEFAULT_ENABLE_MULTISTAGE_MIGRATION_METRIC = false; + public static final String CONFIG_OF_BROKER_ENABLE_DYNAMIC_BROADCAST = + "pinot.broker.enable.dynamic.broadcast"; Review Comment: Could you rename this and other references to `pinot.broker.enable.dynamic.filtering.semijoin`? What this rule does is Dynamic Filtering but only for semi-joins. The dynamic broadcast is an old artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org