somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2023146433
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ########## @@ -987,8 +1010,9 @@ private Pair<InstancePartitions, Boolean> getInstancePartitionsForTier(TableConf } } - private IdealState waitForExternalViewToConverge(String tableNameWithType, boolean lowDiskMode, boolean bestEfforts, - Set<String> segmentsToMonitor, long externalViewCheckIntervalInMs, long externalViewStabilizationTimeoutInMs) + private IdealState waitForExternalViewToConverge(String tableNameWithType, boolean bestEfforts, Review Comment: done, added a log for this scenario -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org