Jackie-Jiang commented on code in PR #15393:
URL: https://github.com/apache/pinot/pull/15393#discussion_r2020040521
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConsumerFactory.java:
##########
@@ -19,12 +19,15 @@
package org.apache.pinot.spi.stream;
import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
/**
* Factory for a stream which provides a consumer and a metadata provider for
the stream
*/
public abstract class StreamConsumerFactory {
+ public static final AtomicInteger CLIENT_ID_SEQ = new AtomicInteger(0);
Review Comment:
Let's add a method `String getUniqueClientId(String prefix)` to access this
to avoid the mis-use (e.g. currently there are mixed usage of
`incrementAndGet()` and `getAndIncrement()`, which is a bug)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
