somandal commented on code in PR #15368: URL: https://github.com/apache/pinot/pull/15368#discussion_r2019838879
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java: ########## @@ -380,6 +464,11 @@ public RebalanceChangeInfo getNumSegmentsInSingleReplica() { public RebalanceChangeInfo getNumSegmentsAcrossAllReplicas() { return _numSegmentsAcrossAllReplicas; } + + @JsonProperty + public ConsumingSegmentToBeMovedSummary getConsumingSegmentToBeMovedSummary() { Review Comment: also, when I search online, e.g. https://www.baeldung.com/jackson-ignore-null-fields https://mkyong.com/java/jackson-how-to-ignore-null-fields/ https://stackoverflow.com/questions/11757487/how-to-tell-jackson-to-ignore-a-field-during-serialization-if-its-value-is-null (found a couple of other links too) it says it should work for the fields themselves and not need to be moved to the getters? has this behavior changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org