nayanika-u commented on code in PR #15226: URL: https://github.com/apache/pinot/pull/15226#discussion_r2019517125
########## pinot-spi/src/main/java/org/apache/pinot/spi/secretstore/SecretStore.java: ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.secretstore; + +import java.util.Map; + +/** + * Interface for managing secrets in Apache Pinot. + * + * This interface abstracts away the details of the underlying secret storage mechanism, + * allowing Pinot to work with various secret management systems like AWS Secrets Manager, + * HashiCorp Vault, or other custom implementations. + * + * Implementations of this interface should handle all aspects of secret management including + * secure storage, retrieval, and cleanup of sensitive information such as connection credentials. + */ +public interface SecretStore { Review Comment: Agree that these will enhance the functionality of SecretStore. Added these methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
