Jackie-Jiang commented on code in PR #14941:
URL: https://github.com/apache/pinot/pull/14941#discussion_r2019059134
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -179,8 +179,13 @@ public enum AggregationFunctionType {
// funnel aggregate functions
FUNNELMAXSTEP("funnelMaxStep", ReturnTypes.INTEGER, OperandTypes.VARIADIC,
SqlTypeName.OTHER),
FUNNELCOMPLETECOUNT("funnelCompleteCount", ReturnTypes.INTEGER,
OperandTypes.VARIADIC, SqlTypeName.OTHER),
+ FUNNELSTEPDURATIONSTATS("funnelStepDurationStats", new
ArrayReturnTypeInference(SqlTypeName.DOUBLE),
+ OperandTypes.VARIADIC, SqlTypeName.OTHER),
FUNNELMATCHSTEP("funnelMatchStep", new
ArrayReturnTypeInference(SqlTypeName.INTEGER), OperandTypes.VARIADIC,
SqlTypeName.OTHER),
+ FUNNELEVENTSFUNCTIONEVAL("funnelEventsFunctionEval", new
ArrayReturnTypeInference(SqlTypeName.VARCHAR),
+ OperandTypes.VARIADIC,
+ SqlTypeName.OTHER),
Review Comment:
(nit) reformat
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/WindowFunnelTest.java:
##########
@@ -883,6 +884,200 @@ public void
testFunnelCompleteCountGroupByQueriesSkipLeaf(boolean useMultiStageQ
}
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testFunnelEventsFunctionEvalGroupByQueries(boolean
useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ String query =
+ String.format("SELECT "
+ + "userId, funnelEventsFunctionEval(timestampCol, '1000', 4, "
+ + "url = '/product/search', "
+ + "url = '/cart/add', "
+ + "url = '/checkout/start', "
+ + "url = '/checkout/confirmation', "
+ + "3, timestampCol, userId, url"
+ + ") "
+ + "FROM %s GROUP BY userId ORDER BY userId LIMIT %d",
getTableName(), getCountStarResult());
+ JsonNode jsonNode = postQuery(query);
+ JsonNode rows = jsonNode.get("resultTable").get("rows");
+ assertEquals(rows.size(), 40);
+ for (int i = 0; i < rows.size(); i++) {
+ JsonNode row = rows.get(i);
+ assertEquals(row.size(), 2);
+ assertEquals(row.get(0).textValue(), "user" + (i / 10) + (i % 10));
+ ArrayNode events = (ArrayNode) row.get(1);
+ if (i < 10) {
+ assertEquals(events.size(), 13);
+ assertEquals(events.get(0).asText().split(",")[0], "1");
+ assertEquals(events.get(0).asText().split(",")[1].trim(), "12");
+ assertEquals(events.get(1).asInt(), 1000);
+ assertEquals(events.get(2).asText(), "user0" + i);
+ assertEquals(events.get(3).asText(), "/product/search");
+ assertEquals(events.get(4).asInt(), 1010);
+ assertEquals(events.get(5).asText(), "user0" + i);
+ assertEquals(events.get(6).asText(), "/cart/add");
+ assertEquals(events.get(7).asInt(), 1020);
+ assertEquals(events.get(8).asText(), "user0" + i);
+ assertEquals(events.get(9).asText(), "/checkout/start");
+ } else {
+ assertEquals(events.size(), 1);
+ assertEquals(events.get(0).intValue(), 0);
+ }
+ }
+ }
+
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testFunnelStepDurationStatsGroupByQueries(boolean
useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ String query =
+ String.format("SELECT "
+ + "userId, funnelStepDurationStats(timestampCol, '1000', 4, "
Review Comment:
(nit) Reformat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
