rhodo commented on PR #15380: URL: https://github.com/apache/pinot/pull/15380#issuecomment-2757074218
> e, shall we publish this metric for all controller/broker/server/minion components? Good call. Let me add it to other services. one question about metrics convention though: It looks like right now metrics naming follows format `pinot_(controller|broker|server|minion)_my_metrics_name`. Correct me if I am wrong but seems we are lacking something like `pinot_common_my_metrics_name` for generic metrics like this zookeeper buffer size, with that we can use a label such as service_name=(controller|broker|server|minion) to distinguish different components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
