albertobastos commented on PR #15278: URL: https://github.com/apache/pinot/pull/15278#issuecomment-2750339732
@Jackie-Jiang > What is the intention of this PR? Within a segment the group count should not go over the numGroupsLimit, will it ever hit the warning limit? This warning aims to be a safeguard in clusters where the numGroupsLimit has been customized with a amount way higher than the 100k default. Our "warning threshold" is a factor against the default limit so under this circumstances, it should be triggered way before the actual user-defined limit arrives. > Logging a warning is not very user friendly. If we really want to track this, we should emit metrics instead. This is the first in a series of 3 pull requests: - Add the threshold and a warning log. - Add a stat with the number of times the log was emitted. - Add a metric with the number of times the log was emitted. The idea was to review, approve and merge each step one by one, but maybe it wasn't the best thought. The third PR with all three additions is here: https://github.com/apache/pinot/pull/15280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
