Jackie-Jiang commented on code in PR #15356:
URL: https://github.com/apache/pinot/pull/15356#discussion_r2010900795
##########
helm/pinot/templates/broker/ingress-v1.yaml:
##########
@@ -20,7 +20,7 @@
{{- if .Values.broker.ingress.v1.enabled }}
{{- $ingressPath := .Values.broker.ingress.v1.path }}
{{- $serviceName := include "pinot.broker.fullname" . }}
-{{- $servicePort := .Values.broker.service.port }}
+{{- $servicePort := .Values.broker.ingress.v1.port | default
.Values.broker.service.port }}
Review Comment:
Is this a bug fix?
##########
helm/pinot/values.yaml:
##########
@@ -90,6 +90,10 @@ pinotAuth:
#
------------------------------------------------------------------------------
controller:
name: controller
+ # Controls whether controller.port is included in the configuration.
+ # Set to false to exclude controller.port when using TLS-only mode or when
+ # you want to specify the port in controller.access.protocols.https.port
instead.
+ configureControllerPort: true
Review Comment:
Instead of introducing this flag, does it work if we simply check if the
port is explicitly configured? IMO that is more user friendly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
