noob-se7en commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r2009563467
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -885,4 +921,21 @@ private void validate(TableConfig tableConfig, Schema
schema) {
// 2. Validate the schema itself
SchemaUtils.validate(schema);
}
+
+ private SemaphoreAccessCoordinator getSemaphoreAccessCoordinator(int
partitionGroupId) {
+ return
_partitionGroupIdToSemaphoreCoordinatorMap.computeIfAbsent(partitionGroupId,
+ k -> new SemaphoreAccessCoordinator(new Semaphore(1),
_enforceConsumptionInOrder, this));
Review Comment:
With lock, Other thread might not be able to unlock the lock acquired by
consumer thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
