vrajat commented on PR #15346: URL: https://github.com/apache/pinot/pull/15346#issuecomment-2745029954
> Is there a new function that super-sedes this deprecated function and does have the BrokerRequest in the method signature ? > > I understand something has been deprecated but ideally the PR that deprecated that API should have also added a newer version of the API that existing users who depended on the deprecated API can move to the new one and continue getting the prior behavior ? The function is not deprecated. Both the implementation in this repo extract the table name from the broker request. Also MSE doesnt check BrokerRequest. This is why we assumed it is OK to consolidate. Also the previous implementation wasnt correct wrt to phase time metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
