noob-se7en commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r2008207970
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java:
##########
@@ -43,6 +43,12 @@ public class StreamIngestionConfig extends BaseJsonConfig {
@JsonPropertyDescription("Whether pauseless consumption is enabled for the
table")
private boolean _pauselessConsumptionEnabled = false;
+ @JsonPropertyDescription("Enforce consumption of segments in order of
segment creation by the controller")
+ private boolean _enforceConsumptionInOrder = false;
+
+ @JsonPropertyDescription("If enabled, Server in-memory tracks the sequence
number of all loaded segments")
+ private boolean _trackSegmentSeqNumber = true;
Review Comment:
HashSet was kept as for some few segment deletion edge cases. Considering
they are not open as of now, I have removed the set.
But we still feel that this feature flag is required to just use ideal state
incase of any unforeseen bug related to segment sequence number during runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
