Jackie-Jiang commented on code in PR #15259:
URL: https://github.com/apache/pinot/pull/15259#discussion_r2004100128
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/H3Utils.java:
##########
@@ -42,13 +43,19 @@ private H3Utils() {
}
public static final H3CoreV3 H3_CORE;
+ public static final H3Core H3_CORE_INSTANCE;
static {
try {
H3_CORE = H3CoreV3.newInstance();
} catch (IOException e) {
throw new RuntimeException("Failed to instantiate H3 V3 instance", e);
}
+ try {
+ H3_CORE_INSTANCE = H3Core.newInstance();
Review Comment:
Seems `H3Core` is preferred over `H3CoreV3`. Currently the naming is
confusing. Suggest renaming `H3_CORE` to H3_CORE_V3`, and we should clean it up
later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
