Jackie-Jiang commented on code in PR #15173:
URL: https://github.com/apache/pinot/pull/15173#discussion_r2003975908
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##########
@@ -117,6 +118,26 @@ public List<SegmentZKMetadata>
getSegmentsZKMetadataForTable(String tableNameWit
return selectedSegmentZKMetadataList;
}
+ public List<SegmentZKMetadata>
getNonConsumingSegmentsZKMetadataForRealtimeTable(String tableNameWithType) {
+ IdealState idealState =
_clusterInfoAccessor.getIdealState(tableNameWithType);
+ Set<String> idealStateSegments = idealState.getPartitionSet();
+ List<SegmentZKMetadata> segmentZKMetadataList =
_clusterInfoAccessor.getSegmentsZKMetadata(tableNameWithType);
Review Comment:
Does it work if we change the validation manager to also fix the UPLOADED
segment when it is in CONSUMING state? That is much easier to manage than
forcing all tasks to apply this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
