wirybeaver commented on code in PR #15265: URL: https://github.com/apache/pinot/pull/15265#discussion_r1999668899
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/custom/ZoneAwareSegmentAssignmentStrategy.java: ########## @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment.segment.strategy.custom; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.TreeMap; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.helix.HelixManager; +import org.apache.helix.model.InstanceConfig; +import org.apache.pinot.controller.helix.core.assignment.segment.strategy.SegmentAssignmentStrategy; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.utils.CommonConstants; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Zone-aware segment assignment strategy that ensures segment replicas are distributed across different availability zones Review Comment: Prefer to abstracting Zone-aware into Isolation-Group Aware. On the pinot-server side, the segment assignment already support Replica Group number awareness and even has the StrictReplicaGroup routing strategy. In Uber infra, we inject on-prem cloud isolation-group number into pinot-server's pool fields as the replica group number. The isolation-group:zone can be 1:1 or 1:m, depending on the company's Cloud Provider implementation. If we can leverage the existing replica-group concept, the duplicate effort on pinot-server side can be avoid. On the pinot-broker side, we can do the same thing, i.e. add the pool field into pinot-broker instance metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
