swaminathanmanish commented on code in PR #15257:
URL: https://github.com/apache/pinot/pull/15257#discussion_r1999172245
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -118,11 +127,20 @@ private void manageRetentionForTable(TableConfig
tableConfig) {
// Scan all segment ZK metadata and purge segments if necessary
if (TableNameBuilder.isOfflineTableResource(tableNameWithType)) {
manageRetentionForOfflineTable(tableNameWithType, retentionStrategy);
+ } else if (isHybridTable(tableConfig)) {
Review Comment:
Can we add a feature flag/param (timeBoundaryBasedRetention) to opt-in so
that we don't change the default behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
