krishan1390 commented on code in PR #15244:
URL: https://github.com/apache/pinot/pull/15244#discussion_r1998592774
##########
pinot-integration-tests/src/test/resources/baseballStats_data.csv:
##########
Review Comment:
yes was previously comparing the actual result of the join and seemed easier
to verify on a smaller file like baseball stats than
On_Time_On_Time_Performance_2014_100k_subset_nonulls.
but now that we're verifying the join through query operator, removed the
assertion of actual count and used
On_Time_On_Time_Performance_2014_100k_subset_nonulls table.
thanks for the suggestion.
##########
pinot-integration-tests/src/test/resources/baseballStats_offline_table_config.json:
##########
@@ -0,0 +1,38 @@
+{
+ "tableName": "baseballStats",
+ "tableType": "OFFLINE",
+ "segmentsConfig": {
+ "segmentPushType": "APPEND",
+ "segmentAssignmentStrategy": "BalanceNumSegmentAssignmentStrategy",
+ "schemaName": "baseballStats",
+ "replication": "1"
+ },
+ "tenants": {
+ },
+ "tableIndexConfig": {
+ "loadMode": "HEAP",
+ "invertedIndexColumns": [
+ "playerID",
+ "teamID"
+ ]
+ },
+ "metadata": {
+ "customConfigs": {
+ }
+ },
+ "ingestionConfig": {
+ "batchIngestionConfig": {
+ "segmentIngestionType": "APPEND",
+ "segmentIngestionFrequency": "DAILY",
Review Comment:
removed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
