noob-se7en commented on code in PR #15268:
URL: https://github.com/apache/pinot/pull/15268#discussion_r1998119910


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1725,6 +1723,20 @@ public RealtimeSegmentDataManager(SegmentZKMetadata 
segmentZKMetadata, TableConf
     }
   }
 
+  // Consumption while downloading and replacing the slow replicas is not 
allowed for the following tables:

Review Comment:
   For upserts I think we should honor the flag, because we are taking snapshot 
before next consumer starts consuming. But for dedup I think we should allow 
next consumer to consume in above case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to