gortiz commented on code in PR #15254:
URL: https://github.com/apache/pinot/pull/15254#discussion_r1991555382
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByCombineOperator.java:
##########
@@ -123,6 +124,7 @@ protected void processSegments() {
if (resultsBlock.isNumGroupsLimitReached()) {
_numGroupsLimitReached = true;
}
+ _numGroups = resultsBlock.getNumGroups();
Review Comment:
This code can be called more than once. In fact what I think you should be
doing is to increase `_numGroups` by `mergedKeys`, which is calculated below.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -148,6 +148,14 @@ public enum ServerMeter implements AbstractMetrics.Meter {
* by 2.
*/
AGGREGATE_TIMES_NUM_GROUPS_LIMIT_REACHED("times", true),
+ /**
+ * Number of times the number of groups has reached the warning limit.
+ * It is increased at most one by one each time per stage.
+ * That means that if a stage has 10 workers and all of them reach the
limit, this will be increased by 1.
+ * But if a single query has 2 different aggregate operators and each one
reaches the limit, this will be increased
+ * by 2.
+ */
+ AGGREGATE_TIMES_NUM_GROUPS_LIMIT_WARNING("times", true),
Review Comment:
Probably we would also like to have a similar metric but not global
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
