bziobrowski commented on code in PR #15205: URL: https://github.com/apache/pinot/pull/15205#discussion_r1991263552
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/distinct/BaseOffHeapDistinctSet.java: ########## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function.distinct; + +import it.unimi.dsi.fastutil.HashCommon; +import java.util.Iterator; +import javax.annotation.concurrent.NotThreadSafe; +import org.apache.pinot.segment.spi.memory.unsafe.Unsafer; +import sun.misc.Unsafe; + + +@NotThreadSafe +public abstract class BaseOffHeapDistinctSet implements AutoCloseable { + protected static final float LOAD_FACTOR = 0.75f; + protected static final Unsafe UNSAFE = Unsafer.UNSAFE; + + protected long _address; + protected boolean _containsZero; + protected int _sizeWithoutZero; + protected boolean _closed; + + public int size() { + return _containsZero ? _sizeWithoutZero + 1 : _sizeWithoutZero; + } + + public boolean isEmpty() { + return !_containsZero && _sizeWithoutZero == 0; + } + + public abstract Iterator<?> iterator(); + + public abstract void merge(BaseOffHeapDistinctSet another); + + public abstract byte[] serialize(); + + @Override + public void close() { + if (!_closed) { + UNSAFE.freeMemory(_address); + _closed = true; + } + } + + @Override + protected void finalize() + throws Throwable { + try { Review Comment: Releasing memory in finalizer means we've a leak so it'd be good to log a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
