albertobastos opened a new pull request, #15229: URL: https://github.com/apache/pinot/pull/15229
There is a test for query cancellation against a MSE that more often than not incurs into a race condition that needs some heavy refactor before can be addresed. A first, quick attempt was made in https://github.com/apache/pinot/pull/15208 but eventually discarded until further discussion. In the meantime, we just increase the horrible hard-coded waiting time for this test. Some notes on the potential refactor (by @Jackie-Jiang): ``` After calculating the routing, query execution is done as: 1. Submit the query to servers 2. Gather responses back 3. Reduce (merge) responses from servers When 1 fails, we should cancel the already submitted ones When 2 fails, we should cancel the ones not responded With this, we can safely start tracking query after 1 before 2 For now I'd suggest to modify the logic to separate 1 and 2+3 as separate abstract method, then change the callback to `onQuerySubmit()` which is invoked after 1. Then we need to address the above scenarios as a follow up ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
