vrajat commented on PR #15240: URL: https://github.com/apache/pinot/pull/15240#issuecomment-2713083375
> > One caveat is that for schema related compilation errors, the user should have read permissions else schema info is leaked. > > Can you provide some examples of the old/new behavior when users have/don't have permissions and the query is compatible/incompatible with the schema? This PR moves the auth check added in #14953 into an if condition. I did this based on an offline conversation where we discussed that this extra check is messing up the compilation and auth time reported in metrics. At least in the successful path, the reported execution time is correct. The original PR also doesnt have a test. @bziobrowski Is there a test already for this condition or did you test it manually ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
