mayankshriv commented on code in PR #15206:
URL: https://github.com/apache/pinot/pull/15206#discussion_r1982754431
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -204,7 +205,11 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
for (String column : existingAllColumns) {
if (_schema != null && !_schema.hasColumn(column)) {
// _schema will be null only in tests
- LOGGER.info("Column: {} of segment: {} is not in schema, skipping
updating forward index", column, segmentName);
+ if
(!CommonConstants.Segment.BuiltInVirtualColumn.ALL_COLUMNS.contains(column)) {
Review Comment:
May be just remove these from `existingAllColumns`, or use filtered iterator
in for loop at 205.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
