Jackie-Jiang commented on code in PR #14971:
URL: https://github.com/apache/pinot/pull/14971#discussion_r1972340163
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java:
##########
@@ -35,4 +34,11 @@ public interface SegmentUploader {
* wait for the specified timeout.
*/
URI uploadSegment(File segmentFile, LLCSegmentName segmentName, int
timeoutInMillis);
+
+ // Added logic (assuming you want this within the method or as part of your
class)
+ default void modifySegmentFileName(String segmentFileName, boolean
removeTarGz) {
Review Comment:
Is this used?
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -265,6 +266,7 @@ private void submitSegmentGenTask(File localTempDir, URI
inputFileURI, int seqId
String segmentName = taskRunner.run();
// Tar segment directory to compress file
localSegmentDir = new File(localOutputTempDir, segmentName);
+ String segmentFileName = segmentName + ".tar.gz";
Review Comment:
Not used?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java:
##########
@@ -35,4 +34,11 @@ public interface SegmentUploader {
* wait for the specified timeout.
*/
URI uploadSegment(File segmentFile, LLCSegmentName segmentName, int
timeoutInMillis);
+
+ // Added logic (assuming you want this within the method or as part of your
class)
Review Comment:
Use javadoc comment
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -223,6 +223,7 @@ public void run()
private void submitSegmentGenTask(File localTempDir, URI inputFileURI, int
seqId)
throws Exception {
+
Review Comment:
(nit) revert
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentUploader.java:
##########
@@ -22,7 +22,6 @@
import java.net.URI;
import org.apache.pinot.common.utils.LLCSegmentName;
-
Review Comment:
(nit) revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
