Jackie-Jiang commented on code in PR #15088:
URL: https://github.com/apache/pinot/pull/15088#discussion_r1970679582
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -392,6 +394,11 @@ public void start()
timeSeriesRequestHandler, _responseStore);
_brokerRequestHandler.start();
+
+ LOGGER.info("Initializing BrokerGrpcServer");
+ _brokerGrpcServer = new BrokerGrpcServer(_brokerConf, brokerId,
_brokerMetrics, _brokerRequestHandler);
+ _brokerGrpcServer.start();
Review Comment:
Move this after `Starting broker admin application` to ensure query related
things are setup (e.g. CPU time measurement)
##########
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcRequestBuilder.java:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.broker.grpc;
+
+import com.google.common.base.Preconditions;
+import com.google.protobuf.ByteString;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.pinot.common.proto.Server;
+import org.apache.pinot.common.request.BrokerRequest;
+import org.apache.pinot.spi.utils.CommonConstants;
+import org.apache.thrift.TException;
+import org.apache.thrift.TSerializer;
+import org.apache.thrift.protocol.TCompactProtocol;
+
+
+public class BrokerGrpcRequestBuilder {
Review Comment:
Should this be merged into the one added in #15081 ?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -392,6 +394,11 @@ public void start()
timeSeriesRequestHandler, _responseStore);
_brokerRequestHandler.start();
+
Review Comment:
(nit) Remove extra empty line
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -146,6 +147,7 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
protected HelixExternalViewBasedQueryQuotaManager _queryQuotaManager;
protected MultiStageQueryThrottler _multiStageQueryThrottler;
protected AbstractResponseStore _responseStore;
+ protected BrokerGrpcServer _brokerGrpcServer;
Review Comment:
Do we want this to be always enabled or configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
